testmycode / tmc-langs

TMC language support framework
2 stars 17 forks source link

Added R support to tmc-langs. #86

Closed anttihaap closed 6 years ago

coveralls commented 6 years ago

Coverage Status

Coverage increased (+0.5%) to 73.78% when pulling 73723c8217d8fbc4d234185714ee59ae58c02958 on RTMC:master into 3e34e49e0aee7c5fe17267c0f13258c5416cb620 on testmycode:master.

ljleppan commented 6 years ago

I'd also consider doing some clean up on the commit history, the 20+ "new try n" commit messages especially are not too helpful :) Discuss this with @nygrenh to determine what -- if anything -- should be done.

nygrenh commented 6 years ago

About the number of commits: I concur with @ljleppan, this pull request shouldn't have this many commits. This doesn't mean I'm expecting you to squash your commits into a single one. Something like 5-10 commits would be appropriate for a pull request of this size.

You can merge your commits with a simple interactive rebase operation. Please see https://git-scm.com/book/en/v2/Git-Tools-Rewriting-History for more details.

coveralls commented 6 years ago

Coverage Status

Coverage increased (+0.5%) to 73.78% when pulling 07d1ebc52b61d96fbb6b304f6ffa6820d30e3022 on RTMC:master into 3e34e49e0aee7c5fe17267c0f13258c5416cb620 on testmycode:master.

coveralls commented 6 years ago

Coverage Status

Coverage increased (+0.6%) to 73.861% when pulling 714579e32d1fea60be3870975a8976c735be38e6 on RTMC:master into 3e34e49e0aee7c5fe17267c0f13258c5416cb620 on testmycode:master.

tmoo commented 6 years ago

@nygrenh and @ljleppan: All the comments should now be addressed, so from our point of view the request seems ready for merging. Let us know if there is something more to consider, though! (Note that the comments about newlines as well as the advised change to RPlugin in the very last comment should be also shown as outdated on this github interface, i.e. the changes are implemented)

ljleppan commented 6 years ago

LGTM, but I'll refer the decision to merge to @nygrenh. Well done :)

nygrenh commented 6 years ago

:tada: