Settings dialog fix - Githubissues

testmycode / tmc-netbeans

Test My Code NetBeans plugin

GNU General Public License v2.0

19 stars 18 forks source link

Settings dialog fix #114

Closed a544jh closed 9 years ago

a544jh commented 9 years ago

Fixed issue #109

a544jh commented 9 years ago

The behaviour should be correct now

jamo commented 9 years ago

Cool, On which platforms have you tried this? Before merging we should test this with

[ ] OSX (I can take care of this)
[ ] Ubuntu
[ ] Windows (comment which)

a544jh commented 9 years ago

I added a test and confirmed that is fails the when WindowListener's actions are not performed. I only managed to get the functional tests running on Windows though.

I've tested that the fix works on the following platforms:

[x] CS department's Ubuntu
[x] Arch Linux with XFCE desktop environment
[x] Windows 10

jamo commented 9 years ago

Sorry, I had totally forgotten to test this on my mac. Great that you got it tested on those. I think it suffices for manual testing.