Optimize Graph.removeFromNodes()

[numeralnathan]

TestNG Version

6.11

Actual behavior

After fixing issue #1390, Graph.removeFromNodes() consumes 60% of the time for TestRunner.initMethods(). Here's the current code.

  private void removeFromNodes(List<Node<T>> nodes, Node<T> node) {
    nodes.remove(node);
    for (Node<T> n : nodes) {
      n.removePredecessor(node.getObject());
    }
  }

Expected behavior

Graph.removeFromNodes() could be optimized if each Node kept a list of its successors. Then only the successors would have to be processed.

As I pointed out in #1390, the predecessor map is almost always empty and hence the successors would almost always be empty. Thus, the impact from Graph.removeFromNodes() could be almost entirely eliminated.

Is the issue reproductible on runner?

• [ ] Shell
• [ ] Maven
• [ ] Gradle
• [ ] Ant
• [X] Eclipse
• [ ] IntelliJ
• [ ] NetBeans

Test case sample

This isn't possible unless I give you all 30,000 test cases. Perhaps, using a DataProvider you could create a test suite with 30,000 test cases and then track how long it takes to execute TestRunner.initMethods().

[juherr]

@nathanila You've made the harder part of the job. Why not proposing a pull request?

[numeralnathan]

I don't know how to do a pull request. Is there some documentation you can point me to on how to do this in Eclipse?

[numeralnathan]

Here's the diff of the changes necessary. These changes eliminates Graph.removeFromNodes() from the profile. The start up time is a lot faster!

Diff.pdf

[krmahadevan]

@nathanila - Sometime back I created a blog that talks about the general set of things that you need to do to setup yourself for contributing into open source projects. You can read read here.

For TestNG, after you have added the code, you need to add some tests, and include those tests into https://github.com/cbeust/testng/blob/master/src/test/resources/testng.xml You then would include the reference to the bug you fixed in this file.

To run the build, from the command prompt you just need to invoke ./build-with-gradle. If you are on windows, then you can perhaps just invoke gradlew --daemon --stacktrace clean build test

I am not sure if it makes sense for someone else to take your diff and submit it as a pull request because

• You are the person who spent figuring out how to fix the problem
• You would be better poised to build proper tests that tests your changes properly

[steveprentice]

Likely dupe of #1710.

[juherr]

We expect the issue will be resolved by #1718.