testng-team / testng

TestNG testing framework
https://testng.org
Apache License 2.0
1.99k stars 1.02k forks source link

Streamline the ITestObjectFactory usage #2679

Open krmahadevan opened 2 years ago

krmahadevan commented 2 years ago

Currently TestNG's object factory instantiation and usage pattern in the codebase is a bit haywire. This needs to be streamlined from the implementation perspective so that, its clear as to when and under what circumstances would TestNG use a global ITestObjectFactory instance and when would it resort to one provided via a suite.

This issue is an outcome from the pull request https://github.com/cbeust/testng/pull/2677

mr-possible commented 10 months ago

Can this issue be closed now because of https://github.com/testng-team/testng/pull/2677 ?

krmahadevan commented 10 months ago

@mr-possible No. i dont think we can close it. This issue is tracking some architecture discrepancies that are highlighted in the linked issue and I dont remember going back to fixing them. Need to recheck as to where we are on this one.