testproject-io / java-opensdk

TestProject Java OpenSDK
Apache License 2.0
50 stars 42 forks source link

Not clear documentation about flag disableReports in driver constructor #105

Closed gil-testproject closed 3 years ago

gil-testproject commented 3 years ago

Here: image

It says that if the flag is true it should disable reports for driver commands.

But the behavior I saw is that it fully disabled any kind of reports. Even calls to driver.report().step("...") not reported.

The description of this parameter seems confusing and suggests that the flag is only to disable the automatic reports that generated by each native driver command. I could not understand from this description that it should also disable any kind of reporting.

Or maybe the behavior I saw is bug and it should work like what the description suggests

gil-testproject commented 3 years ago

Sorry, I missed this part: and tests So I think that I got it wrong by mistake. Closing