fix: avoid setting tp:guid capability if test is executed on IE

testproject-io / java-opensdk

TestProject Java OpenSDK

Apache License 2.0

50 stars 42 forks source link

Closed Artem-Kuz closed 3 years ago

Artem-Kuz commented 3 years ago

relates to #151 Signed-off-by: Artem Kuznetsov artem.kuznetsov@testproject.io

mstrelex commented 3 years ago

@Artem-Kuz

Can you please elaborate on this PR? If you will remove the TP_GUID how the AgentCLient instance will be tracked?

IMHO, if IE doesn't like a capability, it should be removed in the Agent, that initiates the driver and not the SDK who reconstructs it.

s-glatshtein commented 3 years ago

@Artem-Kuz did we not agree that this should be done in agent side and not as part of the SDK?

Artem-Kuz commented 3 years ago

Agreed