search

testproject-io / robot-library

TestProject Library for Robot
Apache License 2.0
6 stars 8 forks source link

Change driver constructor to fit syntax of latest Python SDK #14

Closed Rantzur1992 closed 3 years ago

Rantzur1992 commented 3 years ago

Changed jobname and projectname values to fit the syntax of the latest Python SDK.

Signed-off-by: Ran Tzur ran.tzur@testproject.io

Rantzur1992 commented 3 years ago

@vitalybu Besides the change required from the change in our SDK, there seems to be an issue with set timeout of Chrome and Safari latest builds, I had to remove it for the CI to pass. Also, Evaluate throws an error on the latest Robot build, seems to be a bug on their end.

Had to make this changes for the library to work until they are solved.

vitalybu commented 3 years ago

@vitalybu Besides the change required from the change in our SDK, there seems to be an issue with set timeout of Chrome and Safari latest builds, I had to remove it for the CI to pass. Also, Evaluate throws an error on the latest Robot build, seems to be a bug on their end.

Had to make this changes for the library to work until they are solved.

Maybe it's because you changed the timeout units? Any change that set_script_timeout expects milliseconds? If the tests work (consistently) without it, why was it there in the first place?

Rantzur1992 commented 3 years ago

@vitalybu Besides the change required from the change in our SDK, there seems to be an issue with set timeout of Chrome and Safari latest builds, I had to remove it for the CI to pass. Also, Evaluate throws an error on the latest Robot build, seems to be a bug on their end. Had to make this changes for the library to work until they are solved.

Maybe it's because you changed the timeout units? Any change that set_script_timeout expects milliseconds? If the tests work (consistently) without it, why was it there in the first place?

I didn't change anything regarding to the time units, latest build (which was on December) worked fine and it was as MS, now they changed it to seconds, and regardless, it does not work on Chrome and Safari, it throws an excpetion.

vitalybu commented 3 years ago

@vitalybu Besides the change required from the change in our SDK, there seems to be an issue with set timeout of Chrome and Safari latest builds, I had to remove it for the CI to pass. Also, Evaluate throws an error on the latest Robot build, seems to be a bug on their end. Had to make this changes for the library to work until they are solved.

Maybe it's because you changed the timeout units? Any change that set_script_timeout expects milliseconds? If the tests work (consistently) without it, why was it there in the first place?

I didn't change anything regarding to the time units, latest build (which was on December) worked fine and it was as MS, now they changed it to seconds, and regardless, it does not work on Chrome and Safari, it throws an excpetion.

What doesn't work? What throws an exception? Maybe we shouldn't update to the latest Robot version in this case?

Rantzur1992 commented 3 years ago

@vitalybu Besides the change required from the change in our SDK, there seems to be an issue with set timeout of Chrome and Safari latest builds, I had to remove it for the CI to pass. Also, Evaluate throws an error on the latest Robot build, seems to be a bug on their end. Had to make this changes for the library to work until they are solved.

Maybe it's because you changed the timeout units? Any change that set_script_timeout expects milliseconds? If the tests work (consistently) without it, why was it there in the first place?

I didn't change anything regarding to the time units, latest build (which was on December) worked fine and it was as MS, now they changed it to seconds, and regardless, it does not work on Chrome and Safari, it throws an excpetion.

What doesn't work? What throws an exception? Maybe we shouldn't update to the latest Robot version in this case?

The selenium method in selenium library throws an exception when starting the browsers. The robot version that I used came with our dependency of selenium library.

vitalybu commented 3 years ago

@vitalybu Besides the change required from the change in our SDK, there seems to be an issue with set timeout of Chrome and Safari latest builds, I had to remove it for the CI to pass. Also, Evaluate throws an error on the latest Robot build, seems to be a bug on their end. Had to make this changes for the library to work until they are solved.

Maybe it's because you changed the timeout units? Any change that set_script_timeout expects milliseconds? If the tests work (consistently) without it, why was it there in the first place?

I didn't change anything regarding to the time units, latest build (which was on December) worked fine and it was as MS, now they changed it to seconds, and regardless, it does not work on Chrome and Safari, it throws an excpetion.

What doesn't work? What throws an exception? Maybe we shouldn't update to the latest Robot version in this case?

The selenium method in selenium library throws an exception when starting the browsers. The robot version that I used came with our dependency of selenium library.

And why do you blame this on the Chrome/Safari containers? It works without issues with the Desktop versions? It works with older container builds?

Rantzur1992 commented 3 years ago

@vitalybu Besides the change required from the change in our SDK, there seems to be an issue with set timeout of Chrome and Safari latest builds, I had to remove it for the CI to pass. Also, Evaluate throws an error on the latest Robot build, seems to be a bug on their end. Had to make this changes for the library to work until they are solved.

Maybe it's because you changed the timeout units? Any change that set_script_timeout expects milliseconds? If the tests work (consistently) without it, why was it there in the first place?

I didn't change anything regarding to the time units, latest build (which was on December) worked fine and it was as MS, now they changed it to seconds, and regardless, it does not work on Chrome and Safari, it throws an excpetion.

What doesn't work? What throws an exception? Maybe we shouldn't update to the latest Robot version in this case?

The selenium method in selenium library throws an exception when starting the browsers. The robot version that I used came with our dependency of selenium library.

And why do you blame this on the Chrome/Safari containers? It works without issues with the Desktop versions? It works with older container builds?

Never said the issue is with the containers, it happens on Desktop versions as well.