testpushpleaseignore / acquisition

GNU General Public License v3.0
25 stars 5 forks source link

Add mod makes the mod panel too wide #15

Open aiolos01 opened 2 years ago

aiolos01 commented 2 years ago

When I click on add mod the acquisition window becomes much wider than the screen. If the application is in full screen part of it is outside the visible area without any scroll bars. I need to restore it so I can move it and resize the panels individually which doesn't always work since the vertical separator is sometimes immovable in this situation.

testpushpleaseignore commented 2 years ago

Sorry for not getting back right away, but would it be possible for you to get a recording of this happening to you? I can't seem to be able to recreate this right now, but was just curious as to what you were seeing.

aiolos01 commented 2 years ago

This is a sample of what's happening. In the middle of the video I try to move the vertical separator to the left and it doesn't move. Finally after many attempts I manage to move it. What you don't see is that after I restore the window it's extremely wide and the tabs and item image panels are stuck to the right with minimal width.

On Tue, May 31, 2022 at 2:27 PM testpushpleaseignore < @.***> wrote:

Sorry for not getting back right away, but would it be possible for you to get a recording of this happening to you? I can't seem to be able to recreate this right now, but was just curious as to what you were seeing.

— Reply to this email directly, view it on GitHub https://github.com/testpushpleaseignore/acquisition/issues/15#issuecomment-1142009389, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABSVXZIHTFH6PLOYTPOQKDLVMXZR3ANCNFSM5XFPB7GQ . You are receiving this because you authored the thread.Message ID: @.***>

gerwaric commented 1 year ago

I encountered this bug while working on dynamic rate limiting. I fixed it before I saw this issue. Here's the commit from the branch I'm working on with the change to modfilters.cpp that I think fixes it:

https://github.com/testpushpleaseignore/acquisition/commit/42608fd959c1d8943df6bce24cda2599293cc826