search

tests-always-included / wick

Bash-only IT automation, machine provisioning
Other
69 stars 12 forks source link

Explorer should only output amazon. #107

Closed baelish closed 7 years ago

baelish commented 7 years ago

It was also outputing the ami id causing test to fail, combined with an addition to allow for non vns amazon builds this is a critical bug fix. Consul now tying to eth0 instead of tun0 which causes consul to break.

Explorer output and resulting consul interface before this fix:

amazon-ebs: DEBUG: Explorer stdout:
amazon-ebs: DEBUG: ami-efbee39camazon
amazon-ebs: DEBUG: Explorer stderr:
amazon-ebs: DEBUG: ami-efbee39camazon
amazon-ebs: DEBUG: End of explorer output
amazon-ebs: DEBUG: Explorer success
amazon-ebs: INFO: ***** Base image
amazon-ebs: INFO: *****     Name: logstash
amazon-ebs: INFO: *****     VNS3 Role: logstash
amazon-ebs: INFO: *****     Consul Role: agent
amazon-ebs: INFO: *****     Consul iface: eth0

And after:

amazon-ebs: DEBUG: Explorer stdout:
amazon-ebs: DEBUG: amazon
amazon-ebs: DEBUG: Explorer stderr:
amazon-ebs: DEBUG: amazon
amazon-ebs: DEBUG: End of explorer output
amazon-ebs: DEBUG: Explorer success
amazon-ebs: INFO: ***** Base image
amazon-ebs: INFO: *****     Name: logstash
amazon-ebs: INFO: *****     VNS3 Role: logstash
amazon-ebs: INFO: *****     Consul Role: agent
amazon-ebs: INFO: *****     Consul iface: tun0
fidian commented 7 years ago

Looks good to me.

kyle-long commented 7 years ago

Looks good

baelish commented 7 years ago

Thanks for the quick review! @fidian @kyle-long