search

testshallpass / react-native-dropdownalert

An alert to notify users about an error or something else
MIT License
1.85k stars 252 forks source link

Fix status bar background color android #171

Closed aqos156 closed 5 years ago

aqos156 commented 5 years ago

Fixes #169 StatusBar backgroundColor doesn't go to its default value when moving between screens

codecov-io commented 5 years ago

Codecov Report

Merging #171 into master will decrease coverage by 0.37%. The diff coverage is 66.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #171      +/-   ##
==========================================
- Coverage   71.12%   70.74%   -0.38%     
==========================================
  Files          11       11              
  Lines         187      188       +1     
==========================================
  Hits          133      133              
- Misses         54       55       +1
Impacted Files Coverage Δ
DropdownAlert.js 64.05% <66.66%> (-0.43%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 06082c6...4fc44f1. Read the comment docs.

aqos156 commented 5 years ago

I have added a fix to another issue that my users have found described in https://github.com/testshallpass/react-native-dropdownalert/issues/169#issuecomment-466705346

aqos156 commented 5 years ago

@testshallpass the fix for the new issue referenced in my previous comment is located on line 300. I don't know if this would be the inteded approach, but it works on my device now.