search

testshallpass / react-native-dropdownalert

An alert to notify users about an error or something else
MIT License
1.86k stars 253 forks source link

Added payload to alertWithType() passed down to onClose() #178

Closed rdewolff closed 5 years ago

rdewolff commented 5 years ago

This fixes the issue https://github.com/testshallpass/react-native-dropdownalert/issues/177.

codecov-io commented 5 years ago

Codecov Report

Merging #178 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #178   +/-   ##
=======================================
  Coverage   71.12%   71.12%           
=======================================
  Files          11       11           
  Lines         187      187           
=======================================
  Hits          133      133           
  Misses         54       54
Impacted Files Coverage Δ
DropdownAlert.js 64.47% <ø> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 5c8cd88...ca7db4f. Read the comment docs.

rdewolff commented 5 years ago

What do you think @testshallpass ?

justinobney commented 5 years ago

@rdewolff I think this is a must to make handling onClose viable. That or passing in an onClose callback to alertWithType

rdewolff commented 5 years ago

Can you test and merge this PR?

rdewolff commented 5 years ago

nice! New release can be made ✨ 🎉