iOS 9 wrong dropdown height

testshallpass / react-native-dropdownalert

An alert to notify users about an error or something else

MIT License

1.86k stars 253 forks source link

iOS 9 wrong dropdown height #181

Closed kirillpisarev closed 5 years ago

kirillpisarev commented 5 years ago

Short Description

On iOS 9 initial dropdown height is too big and it raises on each dropdown appearance.

Steps to Reproduce / Code Snippets / Usage

dropdown

Additional Information

React Native version: 0.58.4
react-native-dropdownalert version: 3.9.2
Platform(s) (iOS, Android, or both?): iOS
iOS version: 9

kirillpisarev commented 5 years ago

Like it is said in docs: The purpose of SafeAreaView is to render content within the safe area boundaries of a device. It is currently only applicable to iOS devices with iOS version 11 or later.

So i have changed SafeAreaView to a simple View component for old versions and seems like it is working just fine now.

testshallpass commented 5 years ago

I am onboard with the fix. I reviewed the changes and had some feedback, please take a look. @kirillpisarev

Also, I found out SafeAreaView does not play nice with custom deltas #173

kirillpisarev commented 5 years ago

Your changes now the part of the PR.

testshallpass commented 5 years ago

Merged fix in v3.11.0