testshallpass / react-native-dropdownalert

An alert to notify users about an error or something else
MIT License
1.85k stars 252 forks source link

Omit SafeAreaView for old iOS versions #184

Closed kirillpisarev closed 5 years ago

kirillpisarev commented 5 years ago

181

codecov-io commented 5 years ago

Codecov Report

Merging #184 into master will decrease coverage by 0.07%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #184      +/-   ##
==========================================
- Coverage   71.12%   71.05%   -0.08%     
==========================================
  Files          11       11              
  Lines         187      190       +3     
==========================================
+ Hits          133      135       +2     
- Misses         54       55       +1
Impacted Files Coverage Δ
DropdownAlert.js 64.28% <ø> (-0.19%) :arrow_down:
constants.js 100% <100%> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 5c8cd88...1c387d1. Read the comment docs.

kirillpisarev commented 5 years ago

Could it be merged?