search

testshallpass / react-native-dropdownalert

An alert to notify users about an error or something else
MIT License
1.85k stars 252 forks source link

Put back useNativeDriver: true #186

Closed slorber closed 5 years ago

slorber commented 5 years ago

For me it's working fine on Android, are there reasons anymore to not make this the default?

codecov-io commented 5 years ago

Codecov Report

Merging #186 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #186   +/-   ##
=======================================
  Coverage   71.12%   71.12%           
=======================================
  Files          11       11           
  Lines         187      187           
=======================================
  Hits          133      133           
  Misses         54       54
Impacted Files Coverage Δ
DropdownAlert.js 64.47% <ø> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 5c8cd88...ade4f2e. Read the comment docs.

testshallpass commented 5 years ago

It was originally because it did not work great on earlier react-native version. What react-native version did you run it?

slorber commented 5 years ago

Expo SDK32 which should be RN 0.58 i think