search

testshallpass / react-native-dropdownalert

An alert to notify users about an error or something else
MIT License
1.86k stars 253 forks source link

Add & use react-native-vector-icons #195

Closed erhanbicer closed 4 years ago

testshallpass commented 5 years ago

@erhanbicer Thanks so much. I have recently refactored and will rework your changes.

testshallpass commented 5 years ago

I was also thinking that if you wanted to use react-native-vector-icons you could use renderImage prop to do so and include the dependency in the project.

ardyfeb commented 4 years ago

For dynamic icons we can use https://github.com/WrathChaos/react-native-dynamic-vector-icons and make react-native-vector-icons as peer depedencies because that package need linking

EyMaddis commented 4 years ago

I think that would add unnecessary bloat to applications that do not use vector icons. Especially considering that this is a native dependency, breaking web support.

It would be easy to pass a renderImage function to achieve the same effect.