search

testshallpass / react-native-dropdownalert

An alert to notify users about an error or something else
MIT License
1.85k stars 252 forks source link

[Refactor] DropdownAlert internals #197

Closed testshallpass closed 5 years ago

testshallpass commented 5 years ago

I decided to give the module a refactor so that it is easier to maintain and write tests. I plan to release as a major version.

codecov-io commented 5 years ago

Codecov Report

Merging #197 into master will increase coverage by 18.63%. The diff coverage is 87.22%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master     #197       +/-   ##
===========================================
+ Coverage   71.05%   89.68%   +18.63%     
===========================================
  Files          11       11               
  Lines         190      223       +33     
===========================================
+ Hits          135      200       +65     
+ Misses         55       23       -32
Impacted Files Coverage Δ
CancelButton.js 100% <100%> (ø)
imageview.js 100% <100%> (ø) :arrow_up:
TextView.js 100% <100%> (ø)
constants.js 88.88% <80%> (-11.12%) :arrow_down:
DropdownAlert.js 88.52% <86.53%> (+24.23%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update ffd4b64...8e92ea9. Read the comment docs.