search

testshallpass / react-native-dropdownalert

An alert to notify users about an error or something else
MIT License
1.85k stars 252 forks source link

apply active bar style to android #207

Closed ardyfeb closed 4 years ago

ardyfeb commented 4 years ago

When alert is open the status bar style not changed on android

codecov-io commented 4 years ago

Codecov Report

Merging #207 into master will decrease coverage by 0.78%. The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #207      +/-   ##
==========================================
- Coverage   90.39%   89.61%   -0.79%     
==========================================
  Files          11       11              
  Lines         229      231       +2     
==========================================
  Hits          207      207              
- Misses         22       24       +2
Impacted Files Coverage Δ
DropdownAlert.js 87.43% <0%> (-0.93%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 6b4e874...6b7a070. Read the comment docs.

testshallpass commented 4 years ago

I reworked your changes in PR: Fixes to constants, setBarStyle and unmount don't invoke closeAction #210. I'm going to add some more test coverage.