tesu / PennyPincher

XIVLauncher plugin for undercutters
MIT License
16 stars 21 forks source link

HQ Detection doesn't work / I want to undercut HQ only when listing HQ #13

Closed tesu closed 1 year ago

tesu commented 3 years ago

Below are two instances where an NQ item is being listed but Penny Pincher thinks it is HQ (sourced from #plugin-testing). image image

it seems to happen while listing, not while adjusting prices of items that are already listed

@Looty can you figure out what's wrong? Maybe there are two different offsets needed here, one for listing new items and another (the current one) for updating listed items.

Looty commented 3 years ago

Seems like this happens whenever the user hovers over a different item than was listed- it'll take into account the last item that was hovered on

It looks like the tooltip method is not a guarantee I'll lookout for another method

gucciBane commented 3 years ago

Just noting that I'm experiencing this frequently. Having /penny hq enabled doesn't seem to be making a difference.

tesu commented 3 years ago

@Looty are you still working on this? If not, I'll just revert to the old method of just always undercutting HQ price regardless of HQ status of the item being listed.

Looty commented 3 years ago

Haven't found a solution for this yet.. you can revert

tesu commented 1 year ago

Resolved by #41