search

tesu / PennyPincher

XIVLauncher plugin for undercutters
MIT License
16 stars 21 forks source link

When FFXIV gives you empty results, it still copies a value #25

Closed zandzpider closed 2 years ago

zandzpider commented 2 years ago

image

zandzpider commented 2 years ago

These are 3 empty results in succession, and it pulls out a number (from cache?) Nothing should be done if there are no results (this is a bug from FF, since there are actual items in the list)

tesu commented 2 years ago

Thanks for flagging this. I'm not sure if I can fix this - the plugin inspects network messages to determine what the prices are (there's no cache involved), and in the case of this "rate-limiting" error, the network messages are still sent. The messages are also strange; I think the first page of results gets skipped over when you encounter the error, which is why you get a slightly higher price copied.

zandzpider commented 2 years ago

Interesting. Always wanted to look into the network aspect of this. I'll clone it and fiddle (don't count on anything tho)

zandzpider commented 2 years ago

This PR should fix this issue https://github.com/tesu/PennyPincher/pull/27