search

tesu / PennyPincher

XIVLauncher plugin for undercutters
MIT License
16 stars 21 forks source link

BUG: HQ flag is ignored #43

Closed n3farious closed 1 year ago

n3farious commented 1 year ago

Version: 1.6.0.0 Dalamud: D7.4.5.5

Current Settings: image

Expected behavior: Copy NQ prices unless shift is held. Actual behavior: Copies HQ price unless shift is held.

It appears that the following is not being properly evaluated: "hq": false,

I have uninstalled and reinstalled. I have manually removed the plugin as well as the config file. Behavior remains.

image

n3farious commented 1 year ago

Further investigation shows that it seems to be depending on the quality of item I am listing. If my item is HQ, it matches HQ. If NQ, it matches NQ price. While possibly useful, this is not my desired functionality.

BigMunsBuns commented 1 year ago

Same situation. The plugin updated and broke expected/established functionality. Holding shift is quite bothersome, and I would much prefer if it was an "opt-in" feature.

It honestly seems to be a fringe-case feature for those who actively sell HQ current endgame gear. Even then, if I were selling an item where the HQ mattered, I would personally want to verify the lowest NQ versus lowest NQ price rather rely on faithful blind pasting. As it is, I list a ton of retainer junk and HQ glam items so this has added a bunch of additional button presses that I can't seem to disable?

tesu commented 1 year ago

This will be fixed in the next update. Just need https://github.com/goatcorp/DalamudPluginsD17/pull/1387 to get merged. (Apparently some people also want to keep undercutting their own retainers?!)

n3farious commented 1 year ago

Validated fixed. Thanks!