search

tesu / PennyPincher

XIVLauncher plugin for undercutters
MIT License
16 stars 21 forks source link

[Feature Request] No price copied if item is HQ, but only NQ listed #46

Open KyonKyonxox opened 1 year ago

KyonKyonxox commented 1 year ago

Scenario: PennyPincher is installed and active. Put HQ item up for sale Compare prices. Only NQ item(s) are up for sale.

Expected result: PennyPincher will copy a value based on the items up for sale

Actual result: Clipboard value remains as it was before Compare Prices. No message appearing in chat about values being copied.

Video: https://youtu.be/k3ZSBOiTMzI

I understand why this happened, but it was surprising and not intuitive to see the clipboard hasn't changed. I'm not sure what's a good automated solution for this would be, but could you at least add a message along the lines of 'no HQ items found, not copying value'? At least then it's clear what happened.

HawkAtreides commented 1 year ago

I would like to add a request to this that the plugin put an invalid price (e.g., -1) onto the clipboard. I'm working on a tool that piggybacks off of Penny Pincher and having some "no value copied" magic number put on the clipboard would be an absolute godsend for its functionality.