Add search autocomplete suggestions pop up

tetherless-world / mowgli-etl

DARPA Machine Common Sense (MCS) Multi-modal Open World Grounded Learning and Inference (MOWGLI) Extract-Transform-Load sub-project

MIT License

6 stars 1 forks source link

Add search autocomplete suggestions pop up #136

Closed 123joshuawu closed 4 years ago

123joshuawu commented 4 years ago

Added NodeSearchSuggestions component to NodeSearchBox

Shows top MAXIMUM_SUGGESTIONS search results from input text
Includes links to each NodePage and a link to NodeSearchResultsPage
Throttled server query with wait duration of THROTTLE_WAIT_DURATION milliseconds

Added NodeSearchInput page object

Contains methods for type, clear, and enter
Contains NodeSearchSuggestions object

Other Changes:

Fixed extra right margin in Frame
Override navbar z-index to allow search autocomplete suggestions to overlay

gordom6 commented 4 years ago

@123joshuawu I'd like to be able to use the keyboard to move down and hit enter on an option. Other autocompletes (like react-select or bootstrap-typeahead) can do this. I don't know if @material-ui's can. Can you look into it?

gordom6 commented 4 years ago

@123joshuawu Your code builds on CI, but my system has a TypeScript error:

                <ListItem component="a" href={Hrefs.node(node.id)}>
                  <ListItemText primary={node.label}></ListItemText>
                </ListItem>

I've seen this before in my personal project.

I've hacked around it per the demo code here: https://material-ui.com/components/lists/ And made a commit to that effect.