tetherless-world / nanomine-graph

the visualization web app for nanomine project
MIT License
1 stars 4 forks source link

Surface Treatment attributes not yet appearing #31

Open mdeagen opened 4 years ago

mdeagen commented 4 years ago

The following SPARQL query

PREFIX nm: <http://nanomine.org/ns/>
PREFIX sio: <http://semanticscience.org/resource/>
PREFIX rdfs: <http://www.w3.org/2000/01/rdf-schema#>
SELECT * WHERE {
  ?sample a nm:PolymerNanocomposite ;
          sio:hasComponentPart [ sio:hasRole [ a nm:Filler ] ;
                                 sio:isSurroundedBy [ sio:hasRole [ a nm:SurfaceTreatment ] ;
                                                      a [ rdfs:label ?surf_treat ] ;
                                                      sio:hasAttribute ?surf_treat_attr]
                               ]
} 

returns an empty set. I believe @rashidsabbir addressed this issue recently (we discussed 8/30), pending a push to QA. Including the issue here so that it can be formally closed once the fix is tested and deployed.

mdeagen commented 4 years ago

Update on this: ManufacturerOrSourceName now appears as an attribute for Surface Treatment. There are other attributes that I would expect (graft density, polydispersity, etc), however these may require separate updates to the ontology/setlr.

PREFIX nm: <http://nanomine.org/ns/>
PREFIX sio: <http://semanticscience.org/resource/>
PREFIX rdfs: <http://www.w3.org/2000/01/rdf-schema#>
SELECT DISTINCT ?surf_treat_attr WHERE {
  ?sample a nm:PolymerNanocomposite ;
          sio:hasComponentPart [ sio:hasRole [ a nm:Filler ] ;
                                 sio:isSurroundedBy [ sio:hasRole [ a nm:SurfaceTreatment ] ;
                                                      a [ rdfs:label ?surf_treat ] ;
                                                      sio:hasAttribute [ a ?surf_treat_attr] ]
                               ]
} 

Returns 1 result: http://nanomine.org/ns/ManufacturerOrSourceName

Recommend keeping issue open until these additional attributes are identified and addressed.