search

tetherless-world / twks

Tetherless World Knowledge Store (TWKS), a provenance-aware RDF store
Apache License 2.0
3 stars 1 forks source link

Using `script/cli` creates a new Docker container per invocation #133

Closed Aaron1011 closed 4 years ago

Aaron1011 commented 4 years ago

Running script/cli invokes docker-compose run, which creates a new container. This causes a new Docker container to be created every single time script/cli is invoked, which causes many unused containers to accumulate on the system.

I think it would a good idea for script/cli to either re-use the same Docker container across multiple invocations, or to automatically clear out old containers (since there doesn't appear to be any state shared between invocations).

gordom6 commented 4 years ago

Added --rm to the run command to remove the container after it exits.

gordom6 commented 4 years ago

Please close this issue if it works for you.