Fixed dynamic settings sync bug

tethysplatform / tethys

The Tethys Platform main Django website project repository.

http://tethysplatform.org/

BSD 2-Clause "Simplified" License

92 stars 49 forks source link

Fixed dynamic settings sync bug #898

Closed swainn closed 1 year ago

swainn commented 1 year ago

Fixes a bug with app setting syncing introduced with #890.

Persistent store database settings that were created dynamically using the app.create_persistent_store() method were removed every time Tethys reloaded.
This is because dynamically created settings are not listed in the app.py and were thus being treated as obsolete settings.
This PR makes it so that settings with a dynamic attribute that is True will be ignored when removing obsolete settings.

coveralls commented 1 year ago

Coverage increased (+2.0e-06%) to 99.99% when pulling 8d478504c1df5c708358d52a36e0b7e0692a3056 on dynamic_db_sync_bug into 3409a2cf02a8775a142733dcb7fc72f01ee6ecd1 on main.