search

tethysplatform / tethys

The Tethys Platform main Django website project repository.
http://tethysplatform.org/
BSD 2-Clause "Simplified" License
94 stars 51 forks source link

[FEATURE] SQLAlchemy 2.0 Breaks Tests #918

Open swainn opened 1 year ago

swainn commented 1 year ago

Describe the bug SQLAlchemy 2.0 has been released and several tests have broken as a result.

To Reproduce Steps to reproduce the behavior: See: https://github.com/tethysplatform/tethys/actions/runs/4046759345/jobs/6959950555

Expected behavior We need to investigate what the breaking changes are with SQLAlchemy and decide if updating to 2.0 will constitute a patch, minor, or major release update in Tethys.

Errors/Traceback See: https://github.com/tethysplatform/tethys/actions/runs/4046759345/jobs/6959950555

Screenshots N/A Tethys Environment Information main

Additional context N/A

swainn commented 1 year ago

Looks like the API changes in sqlalchemy 2.0 are significant:

https://www.sqlalchemy.org/blog/2023/01/26/sqlalchemy-2.0.0-released/

However, they have provided a migration pathway in 1.4 that will allow applications to use the 2.0-style API.

swainn commented 1 year ago

ORM Migration Docs: https://docs.sqlalchemy.org/en/20/changelog/whatsnew_20.html#migrating-an-existing-mapping