Various Improvements for Deployment

tethysplatform / tethys

The Tethys Platform main Django website project repository.

http://tethysplatform.org/

BSD 2-Clause "Simplified" License

92 stars 49 forks source link

Various Improvements for Deployment #942

Closed swainn closed 1 year ago

swainn commented 1 year ago

This PR provides the following fixes/improvements for the Docker deployment:

Adds the NGINX_PORT ENV for the Dockerfile to allow setting the port NGINX binds to
In salt scripts, surrounds values used in commands with quotes.

Addresses the following other issues:

Addresses a Django 4 deprecation warning to use gettext_lazy instead of ugettext_lazy.
Fixes a bug with the check for the "migrate" arg before harvesting.
Implements #933

coveralls commented 1 year ago

Coverage: 100.0%. Remained the same when pulling 6b157f5eeace4909012d8746ece93e6f3f20c552 on deployment_improvements into ba9ee4444ff22cfafd71ce8e7531554f54341af7 on main.

swainn commented 1 year ago

@sdc50 did you do any work with making the salt scripts more dynamic/intelligent when you were working on the redhat dockefile? i.e.: they don't run only on the first startup.

sdc50 commented 1 year ago

@sdc50 did you do any work with making the salt scripts more dynamic/intelligent when you were working on the redhat dockefile? i.e.: they don't run only on the first startup.

I've made a few changes, mainly adding additional environment variables to act as flags for certain steps. I'm planning to merge the docker files together at some point.