Proxy Apps with icon to distinguish from native apps

tethysplatform / tethys

The Tethys Platform main Django website project repository.

http://tethysplatform.org/

BSD 2-Clause "Simplified" License

92 stars 49 forks source link

Proxy Apps with icon to distinguish from native apps #989

Closed romer8 closed 11 months ago

romer8 commented 11 months ago

[x] New field added in the ProxyApps model called display_external
[x] Conditional rendering in case the display_external of the proxy app is disable
[x] Migration created
[x] Documentation updated

Icon appearance:

Admin appearance:

coveralls commented 11 months ago

coverage: 100.0%. remained the same when pulling f793e6713adadc86de2336c1e7fd85398d4089b3 on romer8:proxyAppsEdition into 10c63b0020d3c86f20bd668194d282988715e031 on tethysplatform:main.

sdc50 commented 11 months ago

@romer8 I like this approach. I think it may be more clear to have the checkbox label say Display External Indicator. I'm also curious how it looks if the app name is longer. How would it look if the icon were about the same size as the info icon that shows up at the top of the app card?

romer8 commented 11 months ago

@swainn @sdc50 I have changed the style of the icon to look like this:

I have made the name long as well to see if it looks good. The name has been changed in the model and admin page also to look like Display External Icon

swainn commented 11 months ago

I have made the name long as well to see if it looks good. The name has been changed in the model and admin page also to look like Display External Icon

Excellent. I like this version a lot more. I'd like to get feedback from @sdc50 and/or @shawncrawley on this too.