feat: bump php to ">=7.2.5", use new language features of 7.2

tetranz / select2entity-bundle

A Symfony2 bundle that integrates Select2 as a drop-in replacement for a standard entity field on a Symfony form.

MIT License

219 stars 110 forks source link

feat: bump php to ">=7.2.5", use new language features of 7.2 #184

Open Chris53897 opened 2 years ago

Chris53897 commented 2 years ago

Usage stats of 3.1 show 0.x% for php 7.1 https://packagist.org/packages/tetranz/select2entity-bundle/php-stats#3.1

Should be >= 7.4 (but that would exclude 8% of users to upgrade). So i am not sure if it alreday time for this. WDYT?

https://github.com/tetranz/select2entity-bundle/pull/183

knallcharge commented 2 years ago

I'd go with >=7.4 in version 3.2.0 and >=8.0 in 3.3.0 or even a new major version 4.0.0 and add a note in the readme for users with older PHP versions. If you can't update your PHP version, you can stick with an older version of the library, but I don't see a reason not to use new language features because of that.