tetratech / baytrends

Evaluate long-term trends in the Chesapeake Bay using a Generalized Additive Modeling (GAM) approach
https://tetratech.github.io/baytrends/
12 stars 4 forks source link

devtools::check(args = c('--as-cran')) warnings #46

Closed jharcum closed 4 years ago

jharcum commented 4 years ago

Describe the bug

-- R CMD check results ------------------------------- baytrends 1.2.1.8008 ----
Duration: 2m 13.5s

> checking R/sysdata.rda ... OK
   WARNING
  'qpdf' is needed for checks on size reduction of PDFs

> checking dependencies in R code ... NOTE
  Package in Depends field not imported from: 'survival'
    These packages need to be imported from (in the NAMESPACE file)
    for when this namespace is loaded but not attached.

> checking R code for possible problems ... NOTE
  .layerAggregation: no visible global function definition for 'as.qw'
  impute: no visible global function definition for 'Surv'
  selectData: no visible global function definition for 'is.Surv'
  selectData: no visible global function definition for 'Surv'
  Undefined global functions or variables:
    Surv as.qw is.Surv

0 errors v | 1 warning x | 2 notes x
Error: R CMD check found WARNINGs
Execution halted

Exited with status 1.
leppott commented 4 years ago

Still have lingering reference to as.qw in layerAggregations.R (line 224) after 1.2.1.8009 update.

image

jharcum commented 4 years ago

.layerAggregation updated to Surv objects. Running devtools::check(args = c('--as-cran')) leaves qpdf.

image

jharcum commented 4 years ago

Per Erik: For the Ghostscript / qpdf that can be explained away when submitting to CRAN. The Windows build is quite the PITA to install. All it does is check to see if you can compress your PDFs to a smaller size. When submit to CRAN I put it in cran-comments.md. Attached is the one from the last submittal (it is in the root folder of the package).

cran-comments.zip