search

tetratech / baytrends

Evaluate long-term trends in the Chesapeake Bay using a Generalized Additive Modeling (GAM) approach
https://tetratech.github.io/baytrends/
12 stars 4 forks source link

coercion to logical warning #79

Closed jharcum closed 1 year ago

jharcum commented 1 year ago

Below warning reported by RK (april 2023)

Warning in gamANOVAtbl$df < gamPenaltyCrit[1] || gamANOVAtbl$F > gamPenaltyCrit[2]: 'length(x)

= 8 > 1' in coercion to 'logical(1)'

jharcum commented 1 year ago

RK discovered in v2.0.8 was associated with adding notes to the ANOVA table. When the analysis includes censored data, we inspect the degrees of freedom (column labeled edf) and make note in the ANOVA table of where the F-statistic might be unreliable (in our software we check for edf < 1 || edf > 9e9). It appears that these notes were not being added to the ANOVA table correctly. The fix implemented in v2.0.9 corrects for this issue.