tetratech / baytrendsmap

Shiny app to create maps on-the-fly from output of the baytrends package.
https://tetratech.github.io/baytrendsmap/
MIT License
4 stars 2 forks source link

Revise workflow for loading and sorting data #19

Closed jharcum closed 4 years ago

jharcum commented 4 years ago

Describe the solution you'd like See attached mock up Baytrends app.pdf

jharcum commented 4 years ago

Updated example rda and csv files of split out data. See rda for df = fileList for list of files, data frame names, and radio button names.

baytrendsmap_2018_data,R1.zip

jharcum commented 4 years ago

data files in previous comment meet minimum data requirements specified here

leppott commented 4 years ago

Should decide on file names and screen select values so can change the data without updating the app.

image

image

leppott commented 4 years ago

New data files tested with filters. And new column contents come through fine. Example below.

image

leppott commented 4 years ago

v1.0.0.9020 adds radio buttons for files saved within the app.

The first radio button is default and has a button for loading that selection.

Changed the wording slightly for headers.

Need to work on timing and events so can select radio after uploading without reloading the app (F5).

image

jharcum commented 4 years ago

Looks good. I’d say get that 2nd page of workflow going

Jon Harcum, PhD | Principal Engineer/Hydrologist | Tetra Tech Direct (864) 650-5815 | jon.harcum@tetratech.com

This message, including any attachments, may include privileged, confidential and/or inside information. Any distribution or use of this communication by anyone other than the intended recipient is strictly prohibited and may be unlawful. If you are not the intended recipient, please notify the sender by replying to this message and then delete it from your system.

From: Erik Leppo notifications@github.com Sent: Thursday, June 11, 2020 4:12 PM To: tetratech/baytrendsmap baytrendsmap@noreply.github.com Cc: Harcum, Jon jon.harcum@tetratech.com; Manual manual@noreply.github.com Subject: Re: [tetratech/baytrendsmap] Revise workflow for loading and sorting data (#19)

v1.0.0.9020 adds radio buttons for files saved within the app.

The first radio button is default and that file is auto loaded.

Selecting other radio buttons will change the loaded file.

Changed the wording slightly for headers.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHubhttps://github.com/tetratech/baytrendsmap/issues/19#issuecomment-642903236, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ADFUEPJK73AJBTCUNW5YJRTRWE27RANCNFSM4NGBZSIQ.

leppott commented 4 years ago

Added "reset" button for file input but it isn't active.

If select a user file the input doesn't clear so can't select a presaved file.

Renamed long file names otherwise get a warning when build the package that it won't work on some systems due to file path > 100 characters. Defined in global.R.

pick_files_radio <- c("Non-linear Trend (Full Period)" , "Non-linear Trend (2009-2010 to 2017-2018)" , "Non-linear Trend with Flow Adjustment (Full Period)" , "Non-linear Trend with Flow Adjustment (2009-2010 to 2017-2018)") pick_files_names <- c("Trend_NL_FA_F_Full.csv" , "Trend_NL_FA_F_Short.csv" , "Trend_NL_FA_T_Full.csv" , "Trend_NL_FA_T_Short.csv")

leppott commented 4 years ago

For filters will need to modify "Reset Filters" button since using UIoutput for different set of filters based on file type.

leppott commented 4 years ago

Filter UI changes based on whether "user" or "official" file. "Official" shown below.

For now is a select input. Once get other items working (with 2 sets of filters need to tweak other items) then will try for radio buttons. Mixing radio buttons and select input will require further tweaks.

image

leppott commented 4 years ago

Leave mapLayer as selectInput rather than radio buttons. 24 options is too many.

image

leppott commented 4 years ago

Scrapped the radio buttons as taking up too much space. Redesigned selectizeInput() as selectInput() and now have a single pull down list. The list of variables is dependent upon the imported file. This list is unsorted and listed in the order of appearance in the file. So it could be that parameters are not all together.

image

leppott commented 4 years ago

Revisit auto-generate map titles with "official" data.

filters replaced with mapLayer.

image

leppott commented 4 years ago

Set the Map Layer collapse to OPEN so user will always see it.

leppott commented 4 years ago

Range Map

image

Trend Map

image

leppott commented 4 years ago

Still to fix:

leppott commented 4 years ago

Turned off 'reset files' button. Easiest to use "F5" to restart shiny and clear the file names.

Clear filters fixed.

jharcum commented 4 years ago

How will this play out when loaded on CBP’s AWS site?

Jon Harcum, PhD | Principal Engineer/Hydrologist | Tetra Tech Direct (864) 650-5815 | jon.harcum@tetratech.com

This message, including any attachments, may include privileged, confidential and/or inside information. Any distribution or use of this communication by anyone other than the intended recipient is strictly prohibited and may be unlawful. If you are not the intended recipient, please notify the sender by replying to this message and then delete it from your system.

From: Erik Leppo notifications@github.com Sent: Monday, June 15, 2020 1:02 PM To: tetratech/baytrendsmap baytrendsmap@noreply.github.com Cc: Harcum, Jon jon.harcum@tetratech.com; Manual manual@noreply.github.com Subject: Re: [tetratech/baytrendsmap] Revise workflow for loading and sorting data (#19)

Turned off 'reset files' button. Easiest to use "F5" to restart shiny and clear the file names.

Clear filters fixed.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHubhttps://github.com/tetratech/baytrendsmap/issues/19#issuecomment-644254734, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ADFUEPKLX5BURPSIWJYGZ4DRWZHWXANCNFSM4NGBZSIQ.

leppott commented 4 years ago

Save internal reactiveValues and keep track of the last button clicked (official vs. user).

Use that value to determine data to load.

Appears to be working.

Can also display to the user.

image

image

Cannot easily clear the "browse" button but can keep track of the last file loaded. So if click "official" after a "user" file the data changes. And the text for "loaded file type" changes.

image

leppott commented 4 years ago

Modified timing of filters.

Added error message for no data selected.

image

jharcum commented 4 years ago

Is this issue ready to close?