search

tetratelabs / archive-envoy

Archive of Envoy® release binaries
Apache License 2.0
12 stars 4 forks source link

Adds homebrew bump automation #18

Closed codefromthecrypt closed 3 years ago

codefromthecrypt commented 3 years ago

This helps us complete patch releases since Envoy aren't actually doing it, yet.

See https://github.com/envoyproxy/envoy/issues/17500

netlify[bot] commented 3 years ago

✔️ Deploy Preview for archive-envoy ready!

🔨 Explore the source changes: 730980146d4b7d86a15ce1bdf52e459981de4ed0

🔍 Inspect the deploy log: https://app.netlify.com/sites/archive-envoy/deploys/6125b9066ba45f0008b61ba1

😎 Browse the preview: https://deploy-preview-18--archive-envoy.netlify.app

codefromthecrypt commented 3 years ago

This won't work until either the automation can handle git tags or envoy's formula doesn't rely on git.

Thanks to @cho-m for troubleshooting

https://github.com/Homebrew/homebrew-core/pull/83921#issuecomment-905246111

Here's the change needed to the envoy formula (using revision instead of a tag.gz sha)

  # TODO: We can't use the tar.gz archive URL, which means bump-homebrew-formula-action doesn't work. See #83921
  url "https://github.com/envoyproxy/envoy.git",
     tag:      "v1.19.1",
     revision: "a2a1e3eed4214a38608ec223859fcfa8fb679b14"
carlocab commented 3 years ago

You might want to try https://github.com/dawidd6/action-homebrew-bump-formula -- I think this one doesn't choke on formulae that use Git tags + revisions.

codefromthecrypt commented 3 years ago

Thanks, I will switch it and use it next time (next month I suppose would be when another round of patches land)

codefromthecrypt commented 3 years ago

https://github.com/marketplace/actions/homebrew-bump-formula as also mentioned, which maybe the same as the prior!