search

tetratelabs / archive-envoy

Archive of Envoy® release binaries
Apache License 2.0
10 stars 4 forks source link

netlify generation of envoy-versions.json can be flakey due to PR attempts #40

Open trajendran-chwy opened 2 years ago

trajendran-chwy commented 2 years ago

Netlify's execution of the script that generates json makes a curl request to GitHub. This can overrun GH limits if for example, a PR is updated then merged inside a window. We can either stop generating preview URLs or authenticate the job inside netlify somehow.

Original:

https://archive.tetratelabs.io/envoy/envoy-versions.json returns null for all the attributes in the response.

is the service down?

This is on May 17th, 2022.

codefromthecrypt commented 2 years ago

thanks for reporting! This was hitting a GitHub rate limit on building the site, I rebuilt it, but this issue should stay open until the netlify trigger is authenticated somehow

codefromthecrypt commented 2 years ago

I reworded the description after noticing the site failed to generate likely due to being built twice before in the same 10m. Might be wrong, but in any case there are some ways out of this.

Screen Shot 2022-05-17 at 3 56 15 PM
trajendran-chwy commented 2 years ago

Thank you, tried my build and it passed. could you please recommend a best way to ensure this doesn't occur again?

codefromthecrypt commented 2 years ago

Thank you, tried my build and it passed. could you please recommend a best way to ensure this doesn't occur again?

wait for this issue to close. if it is closed, it should never happen again, at least this specific problem (rate limiting)