search

tetratelabs / archive-envoy

Archive of Envoy® release binaries
Apache License 2.0
12 stars 4 forks source link

consider testing arm64 on release #44

Open codefromthecrypt opened 2 years ago

codefromthecrypt commented 2 years ago

Currently, our release tests don't try to test arm64.

# Note: We don't test arm64 on release as it is unlikely to fail and too much effort. https://github.com/tetratelabs/archive-envoy/blob/master/.github/workflows/release.yaml#L63

The reason we felt it unlikely to fail was because we are using the docker images from envoy. However, it seems they aren't tested and recently added the wrong architecture to the image #43

Changing the release job to use qemu to test linux with arm64/aarch64 will at least make troubleshooting this quicker until assurances are made that the envoy docker images are all tested.

https://github.com/tetratelabs/wazero/blob/main/.github/workflows/spectest.yaml#L85 is an example of a job that uses qemu include rate limit avoidance to test non-amd64 with GitHub actions

codefromthecrypt commented 2 years ago

note darwin binaries aren't from envoy docker, rather homebrew, as envoy doesn't publish a darwin docker image.

Moreover, currently envoy isn't kicking off homebrew formula update as a part of their processes, and the formula update routinely fails as there's no CI on HEAD https://github.com/envoyproxy/envoy/issues/17500 We can still add a dimension to test darwin on arm64/aarch64 but we should comment that failures there are not docker related