tetratelabs / istio-distro.io

Tetrate Istio Distro project website, formerly GetIstio
https://istio.tetratelabs.io
Apache License 2.0
6 stars 17 forks source link

Make sure in-eks is nested under install-istio #271

Closed dio closed 1 year ago

dio commented 1 year ago

This makes sure we have a "root" "Istio install" menu, and no more rendering duplication.

Preview:

image

Signed-off-by: Dhi Aurrahman dio@rockybars.com

PetrMc commented 1 year ago

Hi @dio thanks for it, but need a bit more of your help.

(1) I'm attaching video here - submenus are not accessible for any topics - unless user is directed to a subtopic and then menu is extended in navigation bar. 2022-11-26_07-57-06

(2) need a bit more understanding what was happening and why cleaning up markdown removed the Install Istio from the root menu. We're doing bunch of changes to the website and without understanding will step in the problem again.

🙇

dio commented 1 year ago

Yo @PetrMc, I coordinated offline with @nascode. He will provide support for this repo.

@nascode since this is actually "docs", I believe this is under your jurisdiction :).

dio commented 1 year ago

BTW, @PetrMc are you accessing: https://deploy-preview-271--getistio-demo.netlify.app/getmesh-cli/? Or locally?

If locally you need to follow the merged changes to README.md https://github.com/tetratelabs/istio-distro.io/commit/c03fe59ae6a3de2db654536dfc8640db2b338ac4.

Basically, for now, you need to use hugo v0.8.5 extended and node12 (to match the current Netlify env).

nascode commented 1 year ago

Hi @PetrMc

For (1) if you want to test locally, make sure you are using Hugo binary v0.8.5 extended to have same behavior with production build. As for Node, I am using Node v16 successfully. You can get the binary here https://github.com/gohugoio/hugo/releases/tag/v0.85.0 (choose the extended version)

For (2) can you elaborate more?

PetrMc commented 1 year ago

Thanks @nascode and @dio - i tried 0.8.0 earlier woth no luck and will test with 0.8.5 (node 12) tonite and report back.

@nascode For (2) need to understand what caused the install page to be duplicated in two places including root of navbar. So we can avoid making the same mistake again when adding the content.

Btw is there a lint / editor you use as manually updating markdown is lengthy and fields like "date" in header often get ignored?

PetrMc commented 1 year ago

@dio / @nascode - first of all - thank you without your help I would be still scratching my had.

my proposition is to not apply this PR but instead I'll be submitting a new one shortly - that implements the changes here.

hopefully we can apply that one instead as there a lot of context that @ogarrett and myself have reworked for Monday 4PM AWS announcement. (it's when this stuff will go live)

dio commented 1 year ago

AH, OK. very cool. To be honest that was my first time reading this repo. :). Will close the issue.

PetrMc commented 1 year ago

AH, OK. very cool. To be honest that was my first time reading this repo. :). Will close the repo.

Hope you mean - close PR, not Repo :-) Thanks for helping! 🙇