search

tetratelabs / istio-distro.io

Tetrate Istio Distro project website, formerly GetIstio
https://istio.tetratelabs.io
Apache License 2.0
6 stars 17 forks source link

allow WF restart to rebuild site #294

Closed psbrar99 closed 1 year ago

dio commented 1 year ago

I don't think we use gh-pages. Not sure why we have this workflow.

psbrar99 commented 1 year ago

@dio : https://istio.tetratelabs.io (getistio-demo.netlify.app) is using this no ? we want to update this page whenever we have new releases. atm rebuilding the site does the trick?

dio commented 1 year ago

@psbrar99 No. I think you can trigger rebuilding the site using build hooks (https://docs.netlify.com/configure-builds/build-hooks).

Now we have a workflow for it: https://github.com/tetratelabs/istio-distro.io/actions/workflows/update-manifest.yaml

You can manually trigger it (it is also scheduled) via page or CLI:

gh workflow run update-manifest.yaml -R tetratelabs/istio-distro.io
dio commented 1 year ago

Or, I have a PR on https://github.com/tetratelabs/helm-charts/pull/44 so when you update (read: merge changes on) that manifest.json, it will trigger a build.

psbrar99 commented 1 year ago

super helpful! thank you @dio. This is interesting, not sure how the existing workflow was able to refresh the website? i saw the changes happening in gh-pages branch and corresponding effects on the website. Thank you for clarification.

dio commented 1 year ago

AFAIK, looking at the config https://app.netlify.com/sites/getistio-demo/configuration/deploys we only care when something is happening on main branch.

image

The build deploy logs inspector also shows the same thing:

image