Deploy Tetrate Service Bridge Demo on Azure Kubernetes Service (AKS), Google Kubernetes Engine (GKE) and/or Elastic Kubernetes Service (EKS) using Terraform
Apache License 2.0
12
stars
10
forks
source link
Improve skopeo sync and automatically get internal gcr token #146
This changes the jumpbox sync to use skopeo copy and do not require to pull the random busybox image.
It also removes the need to manually pass the internal registry and token when using development versions. The internal registry is very unlikely to change, so this change encapsulates it in the internal_registry module instead.
The only drawback of this change is that the internal token may be generated on every run, but IMO this is a good enough tradeoff: it would only redeploy the jumpbox and at the time of re-running the dev version may already be pointing at a new commit (plus, how many times do we re-apply existing environments? At the time of doing that it is likely that the old token is already expired, so I think it is a good enough tradeoff for simplicity).
Fixes https://github.com/smarunich/tetrate-service-bridge-sandbox/issues/144
This changes the jumpbox sync to use
skopeo copyand do not require to pull the random busybox image.It also removes the need to manually pass the internal registry and token when using development versions. The internal registry is very unlikely to change, so this change encapsulates it in the
internal_registrymodule instead.The only drawback of this change is that the internal token may be generated on every run, but IMO this is a good enough tradeoff: it would only redeploy the jumpbox and at the time of re-running the
devversion may already be pointing at a new commit (plus, how many times do we re-apply existing environments? At the time of doing that it is likely that the old token is already expired, so I think it is a good enough tradeoff for simplicity).