tetratelabs / tetrate-service-bridge-sandbox

Deploy Tetrate Service Bridge Demo on Azure Kubernetes Service (AKS), Google Kubernetes Engine (GKE) and/or Elastic Kubernetes Service (EKS) using Terraform
Apache License 2.0
12 stars 10 forks source link

Refactor TFVAR system - FOR DISCUSSION ONLY #300

Closed boeboe closed 1 year ago

boeboe commented 1 year ago

Small summary

smarunich commented 1 year ago

let's start simple, make.sh need to include the existing Makefile targets - let's not drop the existing functionality: https://github.com/tetrateio/tetrate-service-bridge-sandbox/blob/main/Makefile - for example build/destroy specific cloud, that is a common use case, or onboard specific cloud only to TSB.

I feel like we need to chunk this PR to few when merging to monorepo, as the size of it... and ability to catch all drops in/outs needs time to converge on, by any chance is there a way to split the changes across few PRs? For example, move tflint to a different PR.

Before merging to main as we converge on the common format, one of us have to converge update vars to k8s_clusters to reflect https://github.com/tetrateio/tetrate-service-express-sandbox/blob/main/terraform.tfvars.json.sample