Propose new structure make/bash and general framework

tetratelabs / tetrate-service-bridge-sandbox

Deploy Tetrate Service Bridge Demo on Azure Kubernetes Service (AKS), Google Kubernetes Engine (GKE) and/or Elastic Kubernetes Service (EKS) using Terraform

Apache License 2.0

12 stars 10 forks source link

Propose new structure make/bash and general framework #302

Closed smarunich closed 1 year ago

smarunich commented 1 year ago

to keep the effort simple can you land variables.sh (helper.shz) https://github.com/tetrateio/tetrate-service-express-sandbox/blob/main/make/variables.sh and https://github.com/tetrateio/tetrate-service-express-sandbox/blob/main/make/infra_aws.sh based on the combined feedback with the update to Makefile so we can agree and eventually scale it up to the rest of functions

boeboe commented 1 year ago

New changes:

adopted code review changes
started using linting tool to avoid bash shenanigans
- https://www.shellcheck.net
- https://marketplace.visualstudio.com/items?itemName=timonwong.shellcheck
added parameter input validation on bash functions to increase debug capabilities

Next step: migrate jq => bash functions.