tetrio / issues

Report issues and discuss improvements / feature requests around TETR.IO
https://tetr.io
387 stars 21 forks source link

When saving a file the dialog opens in the background #1273

Closed p1nkl0bst3r closed 4 hours ago

p1nkl0bst3r commented 3 months ago

Checklist

OS and Version

Arch Linux / Linux Mint 21.2

Browser and version

TETR.IO Desktop v9

Describe the bug/issue

When saving a replay the dialog opens in the background after the first time. xprop for main window:

_NET_WM_STATE(ATOM) = 
WM_STATE(WM_STATE):
        window state: Normal
        icon window: 0x0
_NET_WM_DESKTOP(CARDINAL) = 0
_GTK_EDGE_CONSTRAINTS(CARDINAL) = 170
_NET_FRAME_EXTENTS(CARDINAL) = 0, 0, 32, 0
_NET_WM_ALLOWED_ACTIONS(ATOM) = _NET_WM_ACTION_MOVE, _NET_WM_ACTION_RESIZE, _NET_WM_ACTION_FULLSCREEN, _NET_WM_ACTION_MINIMIZE, _NET_WM_ACTION_SHADE, _NET_WM_ACTION_MAXIMIZE_HORZ, _NET_WM_ACTION_MAXIMIZE_VERT, _NET_WM_ACTION_CHANGE_DESKTOP, _NET_WM_ACTION_CLOSE, _NET_WM_ACTION_ABOVE, _NET_WM_ACTION_BELOW
_NET_WM_USER_TIME(CARDINAL) = 1048991
_NET_WM_ICON(CARDINAL) = 
WM_NORMAL_HINTS(WM_SIZE_HINTS):
        program specified location: 160, 119
        program specified minimum size: 800 by 425
        program specified maximum size: 2147483647 by 2147483647
_MOTIF_WM_HINTS(_MOTIF_WM_HINTS) = 0x2, 0x0, 0x1, 0x0, 0x0
XdndAware(ATOM) = BITMAP
_NET_WM_BYPASS_COMPOSITOR(CARDINAL) = 2
WM_NAME(UTF8_STRING) = "TETR.IO"
_NET_WM_NAME(UTF8_STRING) = "TETR.IO"
WM_WINDOW_ROLE(STRING) = "browser-window"
WM_CLASS(STRING) = "tetrio-desktop", "tetrio-desktop"
_NET_WM_WINDOW_TYPE(ATOM) = _NET_WM_WINDOW_TYPE_NORMAL
_NET_WM_PID(CARDINAL) = 6051
WM_CLIENT_MACHINE(STRING) = "mint"
WM_PROTOCOLS(ATOM): protocols  WM_DELETE_WINDOW, _NET_WM_PING, _NET_WM_SYNC_REQUEST

xprop for the dialog:

WM_STATE(WM_STATE):
        window state: Normal
        icon window: 0x0
_NET_WM_DESKTOP(CARDINAL) = 0
_NET_FRAME_EXTENTS(CARDINAL) = 0, 0, 32, 0
_GTK_EDGE_CONSTRAINTS(CARDINAL) = 170
_NET_WM_ALLOWED_ACTIONS(ATOM) = _NET_WM_ACTION_MOVE, _NET_WM_ACTION_RESIZE, _NET_WM_ACTION_SHADE, _NET_WM_ACTION_CHANGE_DESKTOP, _NET_WM_ACTION_CLOSE, _NET_WM_ACTION_ABOVE, _NET_WM_ACTION_BELOW
_NET_WM_STATE(ATOM) = _NET_WM_STATE_MODAL
WM_HINTS(WM_HINTS):
        Client accepts input or input focus: True
        Initial state is Normal State.
        window id # of group leader: 0x4800001
_GTK_THEME_VARIANT(UTF8_STRING) = 
XdndAware(ATOM) = BITMAP
WM_WINDOW_ROLE(STRING) = "GtkFileChooserDialog"
_NET_WM_WINDOW_TYPE(ATOM) = _NET_WM_WINDOW_TYPE_DIALOG
_NET_WM_SYNC_REQUEST_COUNTER(CARDINAL) = 75497486, 75497487
_NET_WM_USER_TIME_WINDOW(WINDOW): window id # 0x480000d
WM_CLIENT_LEADER(WINDOW): window id # 0x4800001
_NET_WM_PID(CARDINAL) = 6051
WM_LOCALE_NAME(STRING) = "C.UTF-8"
WM_CLIENT_MACHINE(STRING) = "mint"
WM_NORMAL_HINTS(WM_SIZE_HINTS):
        program specified minimum size: 662 by 374
        program specified base size: 0 by 0
        window gravity: NorthWest
WM_PROTOCOLS(ATOM): protocols  WM_DELETE_WINDOW, WM_TAKE_FOCUS, _NET_WM_PING, _NET_WM_SYNC_REQUEST
WM_CLASS(STRING) = "TETR.IO", "TETR.IO"
WM_ICON_NAME(STRING) = "blob:https://tetr.io/77bddbd7-af86-4b14-a0c3-22d76a05d7eb"
_NET_WM_ICON_NAME(UTF8_STRING) = "blob:https://tetr.io/77bddbd7-af86-4b14-a0c3-22d76a05d7eb"
WM_NAME(STRING) = "blob:https://tetr.io/77bddbd7-af86-4b14-a0c3-22d76a05d7eb"
_NET_WM_NAME(UTF8_STRING) = "blob:https://tetr.io/77bddbd7-af86-4b14-a0c3-22d76a05d7eb"

Changing the name of the binary from TETR.IO to tetrio-desktop fixes this issue.

Reproducing

No response

Expected behavior

The file dialog opens in the front of the main TETR.IO window.

Screenshots

No response

Console logs

N/A

Additional context

No response

p1nkl0bst3r commented 3 months ago

KDE Plasma 6 now uses the original casing for WM_CLASS when using x11, so renaming the binary does not fix the issue anymore. However, if you are using Wayland and run TETR.IO with the --ozone-platform-hint=auto command the dialog works as expected.

github-actions[bot] commented 2 weeks ago

This bug report has not seen any activity in a while. If the issue is still relevant, please comment on it or the issue will be automatically closed. This way, the issue tracker can be kept clean. Thank you!