tetrio / issues

Report issues and discuss improvements / feature requests around TETR.IO
https://tetr.io
387 stars 21 forks source link

"Pause reply after end" doesn't always show last move #1276

Closed rajun274 closed 1 day ago

rajun274 commented 3 months ago

Checklist

OS and Version

HP Elite Dragonfly 13.5 2022 (16GB) Chromebook

Browser and version

Chrome Version 121.0.6167.212 (Official Build) (64-bit)

Describe the bug/issue

"Pause reply after end" doesn't always show the very last move that a player does, probably because of some timing issue.

Reproducing

Steps to reproduce:

  1. Go to this replay file, which is pointing to the 3rd match: https://tetr.io/#R:MmREYZZ1I@3
  2. The default watch mode is "Exit replay after end".
  3. Watch player DERKMEH until the very end. You'll see that their last moves are LEFT and then HARD DROP: exit_reply_after_end
  4. Go back to that match, but change the watch mode to "Pause reply after end".
  5. Again, watch player DERKMEH until the very end. When the player pauses, the game omits the LEFT: pause_reply_after_end

Note that in my reproduction, it's quite obvious why DERKMEH loses regardless of which watch mode you do. But I reckon that in a scenario where the player misdrops an I piece into a 4-wide well that's in the middle of the board, and they watch the replay and reproduce this bug, it will confuse the player as to why they lost.

Expected behavior

When the video pauses when watching in mode "Pause reply after end", it should show the very last move that all players do.

Screenshots

No response

Console logs

Likely not needed.

Additional context

No response

p1nkl0bst3r commented 3 months ago

related: https://github.com/tetrio/issues/issues/605#issuecomment-763182935

github-actions[bot] commented 2 weeks ago

This bug report has not seen any activity in a while. If the issue is still relevant, please comment on it or the issue will be automatically closed. This way, the issue tracker can be kept clean. Thank you!