search

tetsudai / Lively

The official code repository for the Lively Discord website – a custom website built from the ground up using modern web technologies like HTML5, CSS3 and Bootstrap 4. Learn more in README.md
https://livelydiscord.netlify.com
GNU General Public License v3.0
1 stars 1 forks source link

Where there is not enough content, background image height will end at end of body #10

Open aidswidjaja opened 4 years ago

aidswidjaja commented 4 years ago

Where the content does not fill the entire vh, then the background image will only be as tall as content <body>.

This should not be an issue as we will have enough content to fill the page on normal viewports (e.g phones, tablets, laptops) but could be an issue on a vertical monitor setup. However, it does not render the site completely useless as there is a fallback dark background-color under background-image.

To see in action – fork and deploy the website with only one <h1> and watch the magic!

aidswidjaja commented 4 years ago

One possible solution could be to swap the <body> with <html> but this would ruin the niceness of the code because the <html> tag would be under the <head> tag and the whole world would explode.