set_time_limit() to increase maximum execution time

tetsuo13 / MediaWiki-to-DokuWiki-Importer

Convert MediaWiki to DokuWiki

31 stars 10 forks source link

set_time_limit() to increase maximum execution time #10

Closed sockenklaus closed 12 years ago

sockenklaus commented 12 years ago

This fixes #8 for me.

sockenklaus commented 12 years ago

Commit 38bcc00 checks if the script is invoked in CLI mode an gets the image src path via getLocaleSettingsPath if it is invoked in browser.

tetsuo13 commented 12 years ago

The maximum execution bug is definitely worthy but you've attached two different items to the pull because they're both on your master branch. Please create pull requests off of branches so that multiple requests can be made in isolation from each other. The getLocalSettingsPath() addition needs to be in another issue.

tetsuo13 commented 12 years ago

The call to set_time_limit() only needed to be called once. I went ahead and made the change without merging in your pull request because it called this function within a while() loop and because there are multiple commits not all related to this issue in the request.