search

tetsuo13 / MediaWiki-to-DokuWiki-Importer

Convert MediaWiki to DokuWiki
31 stars 10 forks source link

Did some refactoring so mediawiki2dokuwiki.php is now class based #15

Closed sockenklaus closed 12 years ago

sockenklaus commented 12 years ago

I rewrote mediawiki2dokuwiki.php so it is now class based. I think this makes the script a little bit more "clean" and gives us more possibilities to handle with variable-visibility and code-reuse-issues.

tetsuo13 commented 12 years ago

I don't see the benefit in this proposed change. A rewrite of mediawiki2dokuwiki.php should focus on reducing the file to only executing logic with all declarations and side effects in another file. Encapsulating all variables in a class to reduce passing them around is object orientation just for the sake of it and reduces capabilities for unit testing later.