tettusud / merge-jsons-webpack-plugin

This plugin is used to merge json files into single json file,using glob or file names
https://npmjs.com/package/merge-jsons-webpack-plugin
Apache License 2.0
36 stars 20 forks source link

Error management #12

Closed unsafecode closed 7 years ago

unsafecode commented 7 years ago

It looks like error handling should be done differently, as explain in this SO question:

http://stackoverflow.com/questions/42364742/webpack-plugin-error-management

Otherwise, error will not reported in the output.

Found this issue while debugging why merge stopped writing files without any visibile error.

tettusud commented 7 years ago

Thank you @unsafecode will try to implement it Thank you very much for pointing it out.

Sent from my HTC

----- Reply message ----- From: "unsafecode" notifications@github.com To: "tettusud/merge-jsons-webpack-plugin" merge-jsons-webpack-plugin@noreply.github.com Cc: "Subscribed" subscribed@noreply.github.com Subject: [tettusud/merge-jsons-webpack-plugin] Error management (#12) Date: Wed, May 10, 2017 8:00 PM

It looks like error handling should be done differently, as explain in this SO question: http://stackoverflow.com/questions/42364742/webpack-plugin-error-management Otherwise, error will not reported in the output. Found this issue while debugging why merge stopped writing files without any visibile error.

—You are receiving this because you are subscribed to this thread.Reply to this email directly, view it on GitHub, or mute the thread.

{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/tettusud/merge-jsons-webpack-plugin","title":"tettusud/merge-jsons-webpack-plugin","subtitle":"GitHub repository","main_image_url":"https://cloud.githubusercontent.com/assets/143418/17495839/a5054eac-5d88-11e6-95fc-7290892c7bb5.png","avatar_image_url":"https://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6-9aed-b52498112777.png","action":{"name":"Open in GitHub","url":"https://github.com/tettusud/merge-jsons-webpack-plugin"}},"updates":{"snippets":[{"icon":"DESCRIPTION","message":"Error management (#12)"}],"action":{"name":"View Issue","url":"https://github.com/tettusud/merge-jsons-webpack-plugin/issues/12"}}}

tettusud commented 7 years ago

@unsafecode Plugin is updated with error handling as you suggested ,thank you .