search

tettusud / merge-jsons-webpack-plugin

This plugin is used to merge json files into single json file,using glob or file names
https://npmjs.com/package/merge-jsons-webpack-plugin
Apache License 2.0
36 stars 20 forks source link

Add support for JSON files with BOM bytes #42

Closed pardoman closed 5 years ago

pardoman commented 6 years ago

What

Addresses issue #22 - UTF8 with BOM not working

Details

The fix comes from https://github.com/sindresorhus/strip-bom/blob/master/index.js

QA

I've update the unit test to include a file that contains the BOM bytes, along with some text combining English and Chinese. image

pardoman commented 6 years ago

Please review @tettusud . Thanks.

tettusud commented 5 years ago

@pardoman thank you let me merge, that .ts is the actual file I will copy the code give a new build.

pardoman commented 5 years ago

Awesome, thanks for merging. Looking forward to the library's release.

Edit: Released under version 1.0.18

tettusud commented 5 years ago

Thanks for taking time to work on this