search

teuben / nemo

a Stellar Dynamics Toolbox (Not Everybody Must Observe)
https://astronemo.readthedocs.io
GNU General Public License v2.0
57 stars 42 forks source link

Transpose #36

Closed sathvikrav closed 4 years ago

sathvikrav commented 4 years ago

Modifies the tabtranspose table functionality by adding the alignment parameter as the third parameter with the default value being "n" for no. Parameter only accepts a single char "y" or "n" and is case insensitive. Below is a sample use functionality of the tab transpose function:

image

teuben commented 4 years ago

sorry, should have been clear. For booleans (a true/false) we have a special getbparam() function, it will accept 0/1/y/n/t/f and doesn't care about case. So bool Qalign = getbparam("align") would be the example setting, and then you can treat it like if (Qalign) // true case else ///false case

can you also add the modified tabtranspose.1 manual to the pull request.

sathvikrav commented 4 years ago

I don't think the getbparam function works with 0 or 1.

image

teuben commented 4 years ago

This could be a bug then

On Fri, Jul 24, 2020, 15:47 Sathvik Ravi notifications@github.com wrote:

I don't think the getbparam function works with 0 or 1.

[image: image] https://user-images.githubusercontent.com/28583546/88429627-f4a59d80-cdc4-11ea-94ea-d6b84f235166.png

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/teuben/nemo/pull/36#issuecomment-663704259, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAZ4MGLJDL6QDML6MGNN3P3R5HQNNANCNFSM4PG7EVIQ .

teuben commented 4 years ago

There is a new version of getparam, it will properly parse booleans and allow a much wider (also multilingual) range of responses to true/false, even classy .TRUE. and .FALSE. from the fortran age.