teuben
commented
3 years ago few comments:
- for a non-trivial change to the code at version data should change, if it's an API change the version (now 1.1) should change. In your case the 21-dec-2019 should change, and add your 3 letter acronym
- You seem to have added space in the Makefile, this is not needed. You can checkout the old version again and prevent it to be added to the pull request
-
right now the output says
BSF ccd.out: FAIL 41.6353 31.2251 -1 93 115 BSF ccd.out: EXPECT 41.6266 31.2366 -1 93 115
Compared to the TESTSUITE: lines, we should align (i.e. add 2 space) and also put the filename (ccd.out) after the values. This way things align and it's easier for the eye
BSF: FAIL 41.6353 31.2251 -1 93 115 ccd.out
BSF: EXPECT 41.6266 31.2366 -1 93 115 ccd.out
These changes can be seen when one runs the regression test, "make check". This was done to make viewing and analyzing the result of the test easier.