teuben / nemo

a Stellar Dynamics Toolbox (Not Everybody Must Observe)
https://astronemo.readthedocs.io
GNU General Public License v2.0
57 stars 42 forks source link

Using stricter .SH regex #71

Closed ParkerTewell closed 3 years ago

ParkerTewell commented 3 years ago

Also deleted checkBin because it's useless

teuben commented 3 years ago

something went wrong here, not sure what yet. I had 48 bad files before this patch, and now 72. Many files have no entried in the man[] list. E.g. ccdfits. Prviously there were a whole bunch, because it was one of the bad ones.

ParkerTewell commented 3 years ago

This is caused by the .SH "PARAMETERS" in ccdfits and other man pages. My regex strictly looks for .SH PARAMETERS. I can change the regex to expect 1 or none quotation marks at the beginning and end of PARAMETERS. (But it would be best if I detect one that the other would be required. Not sure how to do that off the top of my head but I'll do some research)

Should we include these quotation marks as valid syntax?

On Sun, Jul 4, 2021 at 10:56 AM Peter Teuben @.***> wrote:

something went wrong here, not sure what yet. I had 48 bad files before this patch, and now 72. Many files have no entried in the man[] list. E.g. ccdfits. Prviously there were a whole bunch, because it was one of the bad ones.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/teuben/nemo/pull/71#issuecomment-873606662, or unsubscribe https://github.com/notifications/unsubscribe-auth/AH7PRPKBYMS7AS54WAW3EOLTWBZBZANCNFSM47YY7GSQ .

-- Parker Tewell B.S. Computer Science - UMD